Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zip builds more portable (python & ffmpeg) #1484

Merged
merged 5 commits into from
Jan 14, 2023
Merged

Conversation

joeyballentine
Copy link
Member

This PR does three things:

  • Moves the forge config out of package.json and into its own config file
  • Uses a build hook to write a portable file to the zip, if the build is a zip
  • Checks for the existence of this file when checking for python/ffmpeg, and if the file exists will use the current executable directory rather than appdata.

Note: Settings still save to appdata. I will accomplish that next.

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty portable file seems like a hack to me, but it's fine for now, I guess.

src/main/backend/setup.ts Outdated Show resolved Hide resolved
@joeyballentine
Copy link
Member Author

The empty portable file seems like a hack to me, but it's fine for now, I guess.

That's quite literally the only way i can possibly think of to do it

@RunDevelopment
Copy link
Member

I would probably make it a setting we don't show in the UI, but I honestly think that we should rethink how we store settings anyway. The whole "I'm shadowing built-in localStorage" doesn't smell like a best practice to me either.

So let's keep the portable file for now and think about settings as a totality later.

RunDevelopment
RunDevelopment previously approved these changes Jan 14, 2023
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. GTG otherwise. Feel free to merge after resolving the comment.

src/main/backend/setup.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants