-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for single character (emoji) icons #1831
Conversation
- aimed at non-latin chars (incl. emoji)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
CI is failing, because we apparently don't use lib ES2022. I made a PR for that #1833, so this will be possible soon.
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Co-authored-by: Joey Ballentine <34788790+joeyballentine@users.noreply.github.com>
Open Sans and Noto Emoji alone aren't enough to support all non-latin characters. Bundling a lot of font files for this will bloat the application size. I will look to add local Noto variants for: latin, CJK, arabic, devanagari, bengali, cyrillic with the view that more can be added as and when needed. |
It's good enough. Let's make some nodes that actually use single character icons before trying to make the feature perfect ;) |
Thanks again for this! Sorry for things being a bit slow lately, I'm hoping to get more development rolling soon |
Aimed at non-latin chars (incl. emoji) using Intl.Segmenter. Noto Emoji is used to keep appearance consistent across platforms.