Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for single character (emoji) icons #1831

Merged
merged 7 commits into from
Jun 4, 2023
Merged

Added support for single character (emoji) icons #1831

merged 7 commits into from
Jun 4, 2023

Conversation

jackcarey
Copy link
Contributor

Aimed at non-latin chars (incl. emoji) using Intl.Segmenter. Noto Emoji is used to keep appearance consistent across platforms.

Screenshot 2023-05-25 084513

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

CI is failing, because we apparently don't use lib ES2022. I made a PR for that #1833, so this will be possible soon.

src/renderer/components/CustomIcons.tsx Outdated Show resolved Hide resolved
jackcarey and others added 2 commits May 25, 2023 01:33
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
jackcarey and others added 2 commits June 4, 2023 01:23
Co-authored-by: Joey Ballentine <34788790+joeyballentine@users.noreply.github.com>
@jackcarey
Copy link
Contributor Author

Open Sans and Noto Emoji alone aren't enough to support all non-latin characters. Bundling a lot of font files for this will bloat the application size. I will look to add local Noto variants for: latin, CJK, arabic, devanagari, bengali, cyrillic with the view that more can be added as and when needed.

@RunDevelopment
Copy link
Member

Open Sans and Noto Emoji alone aren't enough to support all non-latin characters.

It's good enough. Let's make some nodes that actually use single character icons before trying to make the feature perfect ;)

@joeyballentine joeyballentine merged commit 620ab8e into chaiNNer-org:main Jun 4, 2023
5 checks passed
@joeyballentine
Copy link
Member

Thanks again for this! Sorry for things being a bit slow lately, I'm hoping to get more development rolling soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants