-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip download progress reporting #1885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is the status code even for? It's not like it's checked anywhere. We currently just log it, but that seems pretty useless. If an error occurs, then the status code likely won't tell you much.
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Assuming this is good. Merging so I can work on the optional dep installation with progress reporting |
This PR adds the ability for us to report on native pip downloads, via a build of my pip fork. This can be replaced in the future when the change gets merged into pip and released.
The bundled pip is slightly modified from my fork, in that I renamed every instance of "pip" to "chainner_pip" so it wouldn't overwrite the normal pip.
I tested it, and it works pretty well.