Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more doc information for other input types #1929

Merged
merged 7 commits into from
Jul 14, 2023
Merged

Conversation

joeyballentine
Copy link
Member

image
image
image
image

@joeyballentine joeyballentine changed the title Add more information for other input types Add more doc information for other input types Jul 9, 2023
@RunDevelopment
Copy link
Member

My thoughts in no particular order:

  • I like listing dropdown variants.
  • We use minimum text length 0 vs 1 inconsistently, so we should probably treat them the same. Also, I don't think that showing min len = 0/1 has much value, because it pretty much means that there is no required minimum length.
  • I think we shouldn't show numeric precision. All our number inputs with precision >=1 can deal with any number of decimal digits (I think). As I see it, limiting the number of decimal digits is a pure UI thing, and not part of the function of a node.
  • Numeric minimum and maximum are already part of the type, so I don't see why we would repeat it.

About numbers again: if you think that number types are too unclear to new users (and I agree), then we could add tooltips to types that explain them. E.g. int(10..) could have the tooltip text "An integer that is at least 10."

@RunDevelopment
Copy link
Member

image
image

Not the most natural of language.

@joeyballentine joeyballentine mentioned this pull request Jul 13, 2023
@joeyballentine
Copy link
Member Author

image

@joeyballentine
Copy link
Member Author

Assuming this is good now and merging

@joeyballentine joeyballentine merged commit d76e032 into main Jul 14, 2023
4 checks passed
@joeyballentine joeyballentine deleted the more-info branch July 14, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants