Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Upscaling Node Docs + Input Hints #1937

Merged
merged 9 commits into from
Jul 16, 2023
Merged

Conversation

joeyballentine
Copy link
Member

  • Upscaling node doc improvements
  • The hint feature discussed on discord. It applies to both labeled and generic inputs, though I really only ever see it being useful for labeled ones, particularly dropdowns,

image

image

@RunDevelopment
Copy link
Member

Here's what I found:

  1. The (i) icon is too small. It's readable on default zoom. image I'm not sure how to fix this.
  2. Please add an opening delay to the tooltip. Having a random tooltip pop open every time to move your mouse over a node is annoying.
  3. The text is rendered differently in the tooltip and in the docs. This is because the tooltip just ignores Markdown. We already have the code to render markdown in tooltip (for node descriptions), so please use that.
    image

@joeyballentine
Copy link
Member Author

image

image

I changed it to one that can (IMO) be more easily identified at a smaller scale.

@joeyballentine
Copy link
Member Author

image
and now this uses markdown

@RunDevelopment
Copy link
Member

I changed it to one that can (IMO) be more easily identified at a smaller scale.

It's even harder to read for me now 😄

How about we make the original icon bigger? It was smaller than an upper case letter, so maybe we could make the size of the "T"/"S"?

@joeyballentine
Copy link
Member Author

image

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works. Thanks!

@joeyballentine joeyballentine merged commit 44ae32d into main Jul 16, 2023
13 checks passed
@joeyballentine joeyballentine deleted the input-hint-docs branch July 16, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants