Changed empty-string behavior of text inputs #1954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
min_length
is now 0.allow_empty_string
is true, then they will treat an empty input as the empty string.Open question: current save files.
Current save files can have the empty string in text inputs that previously already had min_length=0 and that now do not allow the empty string. This creates a weird situation where the empty string is a valid input as long as you don't touch it (then it will be removed).
How should we deal with this? Should we just live with this weirdness? Should we reset non-allowed empty string input to "no value" and break some chains? Should we make a migration?