Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Navi 0.6.0 #2001

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

RunDevelopment
Copy link
Member

Changes:

  • Upgrade to navi@0.6.0
  • Removed unnecessary int casts. The improved arithmetic in 0.6.0 means that Navi doesn't return +-inf anywhere like before.
  • Removed toJson. The function was unused.
  • Account for scopes. Builtin functions now always get the current scope as the first argument.
  • Changing handling of structs. 0.6.0 significantly changed the layout of structs, so I had to change a lot of code.

About how structs changes: Structs kinds were previously differentiated by their name. E.g. the Image struct was a different kind than the Color struct. Instead of using the name, structs now have a descriptor that identifies the kind. Aside from the name, the descriptor also contains the field names, field definition types, and the default instance of the type (= all fields being the definition type).

@joeyballentine joeyballentine merged commit 4485a8f into chaiNNer-org:main Jul 28, 2023
14 checks passed
@RunDevelopment RunDevelopment deleted the navi-0.6.0 branch July 28, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants