Changed default tile size to 256 for ONNX #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it possible for people with only 4GB of VRAM to upscale using ESRGAN models.
I chose 256, because it only required 3.2 GB of RAM to upscale an 1k RGB image on my system. 512 required 9.1GB, which makes it a non-starter for cards with only 8GB VRAM.
378 required only 5.3GB of VRAM, but took 3 times as long as 256 and 512 on my system (about 30sec (256/512) vs 1min 30sec (378)). I don't know whether other systems behave similarly, but I don't want to risk it.