Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slight adjustments for light mode #2064

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

stonerl
Copy link
Collaborator

@stonerl stonerl commented Aug 7, 2023

Some screenshots for reference:

CleanShot 2023-08-07 at 12 39 40@2x
CleanShot 2023-08-07 at 12 39 23@2x

@stonerl
Copy link
Collaborator Author

stonerl commented Aug 7, 2023

should have been a draft

@joeyballentine
Copy link
Member

A definite improvement over what's there now. I kinda feel like it's just too bright in general though. One thing I've always wanted to try was making the background more or a gray and the nodes lighter rather than the other way around. Would you mind trying that out?

@joeyballentine joeyballentine marked this pull request as draft August 7, 2023 18:28
@stonerl
Copy link
Collaborator Author

stonerl commented Aug 8, 2023

I had to increase brightness to give more contrast to individual elements.

I can try to implement your suggestion. But it could be very difficult since it might sacrifice overall contrast again.

As @RunDevelopment said, since the light theme was an afterthought, it is quite difficult to properly implement it within the current confinements.

In the mid to long run, it would be a good idea to rethink theming and adding more css attributes to have a more nuanced way to theme the app.

I'll set this on my todo list if I find some time.

@joeyballentine
Copy link
Member

Do you think the changes you have a good enough for now? I'd like to get this in if you think it's ready

@stonerl
Copy link
Collaborator Author

stonerl commented Aug 11, 2023

Do you think the changes you have a good enough for now?

Yes, this can go in.

@joeyballentine joeyballentine marked this pull request as ready for review August 11, 2023 22:36
@joeyballentine joeyballentine merged commit 57138ca into chaiNNer-org:main Aug 12, 2023
4 checks passed
@stonerl stonerl deleted the light-theme branch August 17, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants