Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved threshold nodes #2091

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

RunDevelopment
Copy link
Member

Changes to Threshold:

  • Use enum input for threshold type.
  • Make max value conditional. It's only used for binary and binary inverted thresholds.

Changes to Threshold (Adpative):

  • Use enum inputs.
  • Reordered inputs to match Threshold node.
  • Renamed "Mean Subtraction" to "Constant Subtraction" and changed its range to -100 to 100.
  • Added docs.

This also includes a breaking change. Constant Subtraction in Threshold (Adpative) was previously an 8-bit value. This leaked the fact that we use 8-bit images under the hood, so I changed to 0-100 to be consistent with everything else in the threshold nodes.
I did not write a migration for this, because it's a pain, and because I am certain that nobody uses this node. It's complex, confusing, and undocumented, so I don't feel bad breaking chains that use it...

image

@joeyballentine joeyballentine merged commit b51f024 into chaiNNer-org:main Aug 14, 2023
14 checks passed
@RunDevelopment RunDevelopment deleted the threshold-impr branch August 14, 2023 21:57
stonerl pushed a commit to stonerl/chaiNNer that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants