Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code pertaining to old iterators #2267

Merged
merged 9 commits into from Oct 16, 2023
Merged

Remove code pertaining to old iterators #2267

merged 9 commits into from Oct 16, 2023

Conversation

joeyballentine
Copy link
Member

No description provided.

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This might be my favorite PR.
  2. You were right. Z-ordering still works perfectly even without our custom code.
  3. Could you add a migration that removes all the old iterator junk from save data? So all the iterator-related props and our manually-set z-indexes.

@joeyballentine
Copy link
Member Author

The iterator-related props (i assume you mean the iterator size and whatnot) is already gone because the old-to-new migration made new nodes rather than updating the existing ones (and i left that out for obvious reasons).

Removing the zindex fields was a good call though.

I looked through an old chain and i'm pretty sure that's all we need to remove.

@joeyballentine joeyballentine merged commit 91eae95 into main Oct 16, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants