Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alpha matting node #2292

Merged
merged 1 commit into from Oct 31, 2023
Merged

Add alpha matting node #2292

merged 1 commit into from Oct 31, 2023

Conversation

RunDevelopment
Copy link
Member

image
image

Changes:

  • Added alpha matting node.
  • Removed vendored pymatting and added PyMatting and numba as a dependency of chainner_standard.

Options questions:

  • We don't need numba as a direct dependency anymore. Should I remove it, which will make a transitive dependency (pymatting -> numba)?

@joeyballentine
Copy link
Member

We should keep numba because we've had issues when it tries to install specific versions we aren't expecting. I'd prefer to have its version pinned

@RunDevelopment
Copy link
Member Author

Sounds good.

@joeyballentine joeyballentine merged commit dff3c12 into chaiNNer-org:main Oct 31, 2023
14 checks passed
@RunDevelopment RunDevelopment deleted the alpha-matting branch November 3, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RunDevelopment @joeyballentine