Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix execution buttons disabled state #2316

Merged
merged 2 commits into from Nov 5, 2023
Merged

Fix execution buttons disabled state #2316

merged 2 commits into from Nov 5, 2023

Conversation

joeyballentine
Copy link
Member

Fixes #2307

Thanks to hanrai for noticing this in the first place.

And sarcastic thanks to chakra ui for making a breaking change to their props but not their associating TS types 馃檮

joeyballentine
joeyballentine commented Nov 5, 2023
View reviewed changes
Copy link
Member Author

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt need a review

@joeyballentine joeyballentine merged commit 106e9eb into main Nov 5, 2023
4 checks passed
@joeyballentine joeyballentine deleted the fix-buttons branch November 5, 2023 17:15
@RunDevelopment
Copy link
Member

RunDevelopment commented Nov 5, 2023 •
edited

And sarcastic thanks to chakra ui for making a breaking change to their props but not their associating TS types 馃檮

Tag them, coward

@joeyballentine
Copy link
Member Author

So it shows up on that issue: chakra-ui/chakra-ui#7269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interface window buttons cannot enter disabled state
2 participants
@joeyballentine @RunDevelopment