Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how nodes are sorted #2323

Merged
merged 2 commits into from Nov 10, 2023
Merged

Conversation

RunDevelopment
Copy link
Member

Changes:

  • Categories and node groups have IDs now. No more "name == id". The value for those ids is the name though. We can change that if needed though.
  • Node groups are now a datatype in the frontend too. This means that we can add more metadata to change their appearance/behavior in the future.
  • Refactored some frontend code.

The basic idea now is that the backend declares the order of categories, node groups, and some nodes (order), but it does not enforce it. So nodes from /nodes may be in any order. The frontend is responsible for applying that order. It currently does via the sortNodes method. Basically, the first thing the frontend does when getting the response from /nodes is to sort them. Not sure whether the backend should just do that as well.

@joeyballentine joeyballentine merged commit 95343f5 into chaiNNer-org:main Nov 10, 2023
17 checks passed
@RunDevelopment RunDevelopment deleted the sort-cat branch November 10, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants