ncnn: Allow configuring multithreading #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know you guys are busy with the iterator rewrite, so feel free to take your time on reviewing this. |
JeremyRand
force-pushed
the
ncnn-threads
branch
from
1d248ff
to
13b3990
Compare
added 3 commits
November 28, 2023 08:13
No change in current behavior.
RunDevelopment
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Code looks good, but I can't judge whether these changes make sense since I have no idea about NCNN.
@joeyballentine Could you please take a look at this?
|
It only affects CPU mode which (afaik) is only used by Jeremy so I think it's fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informal test results of tweaking these settings on my POWER9 system: