Update Spandrel again + fixes #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't you just do
|
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Yes. But that's bad python code to write it that way and it's kinds inconvenient to have to temporarily swap to that |
RunDevelopment
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last PR didn't switch to using the new call API, for models like MM-RealSR weren't working. Also, since the call API is type-safe, I was able to see that inpainting models would never be able to be interpolated since we weren't handling their two-image parameter requirement.
I'm unable to use the call API for face inference though, since codeformer has no option for its weight through that. That's not too much of an issue though.
Side note: We'll probably want to add a method to go alongside the call api that does the same thing. I realized when doing this that when you use the call API, you can't hover over anything to have vscode show you the args of the function.