Replace global execution options with node context parameter #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the global mutable execution options and replaces them with a node context parameter:
context: NodeContext.The new parameter is opt in and can be enabled in
@registerwith thenode_contextproperty. This not only minimizes the diff (I didn't want to change all nodes), it might also enable optimizations in the future.Right now, the
NodeContextclass has 2 aspects to it: settings and progress. Settings and other execution options are now accessed through the node context parameter. While only the settings aspect is currently used, I also laid the groundwork for per-node progress, which will be my next goal.