Rename "Defer errors" to "Stop on first error" #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyballentine
force-pushed
the
rename-defer-errors
branch
from
03fc96e
to
87ceef8
Compare
|
Does this need a migration? |
|
I like the new label for the input, but I'm not a fan of the internal |
We don't do migrations for unstable changes. Deferring the errors was the old behavior in stable so therefore this is correct. If people made chains in a nightly version and those are now broken, that doesn't need a migration because they signed up for unstable changes when they used the nightly (imo) |
|
Going to merge this so I can get it in today's nightly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @adegerard on Discord.
I had to invert how this boolean behaves for it to make sense. I think this is a much better and more intuitive label for it.