Update to spandrel v0.2.1 #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When we update spandrel, we should also always update the link to the supported models section in the readme. I linked to the specific version we use so that it's always correct for whatever chaiNNer currently supports. |
|
Can't we reasonably expect that chainner will always be close to up to date? I don't think it's a huge problem when the spandrel README lists a few archs that chainner will only support in the next release. |
|
That's a good point. In that case, can you update it to just point to the normal readme? |
joeyballentine
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2461.
This updates spandrel to v0.2.1 and changes our code to take advantage of the new API and guarantees. E.g. since spandrel now handles size requirements, I was able to remove our padding code.