Fix lineage checks in UI #2494
Merged
Fix lineage checks in UI #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe this would be better suited to a follow up PR, but I kinda wonder if we should change the verbiage we use to use a more user-friendly term rather than iterator. From a user perspective, any iterator/iterable is just a sequence, list, batch, etc rather than something that iterates over some data. Perhaps we can explain it that way? I'm not super sure about that though |
Co-authored-by: Joey Ballentine <34788790+joeyballentine@users.noreply.github.com>
Co-authored-by: Joey Ballentine <34788790+joeyballentine@users.noreply.github.com>
joeyballentine
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2266.
This PR fixes the lineage checks for nodes. They should just work now, even in more difficult cases. I also added lineage checks to
checkNodeValiditywhich ensures that a chain with invalid lineage never makes it to the backend. This also means that we now see lineage errors in the footer.Note: It is still possible to create invalid connections using the context node selector. I haven't touched that part of the code yet. However, invalid connections will be correctly detected as such. I'll fix the context selector in a follow-up PR.
Examples:
