Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom scales for PyTorch upscale #2613

Merged
merged 1 commit into from Feb 25, 2024

Conversation

RunDevelopment
Copy link
Member

This allows users to set a custom scale for the PyTorch models to upscale to any scale. This will hopefully make chainner easier to use for our users.

image

Copy link
Member

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as it saddens me that this is necessary (and defeats the point of having nodes), this will at least stop people from needing to ask why chaiNNer doesn't support custom scales like other UIs. So this is ultimately a good change.

@joeyballentine joeyballentine merged commit 65e0f4f into chaiNNer-org:main Feb 25, 2024
14 checks passed
@RunDevelopment RunDevelopment deleted the custom-scale branch February 25, 2024 20:52
@RunDevelopment
Copy link
Member Author

As much as it saddens me that this is necessary (and defeats the point of having nodes)

I mean, it's a common-enough use case, so I honestly think we should have added this sooner. Having some duplicate functionality for convenience isn't a bad thing IMO. E.g. we also had 2 resize nodes until recently (and even Resize to Side) even though all of this functionality can be achieved with Resize (Resolution) and a few Math nodes (and a bit of pain).

@joeyballentine
Copy link
Member

True. I guess there's nothing wrong with adding a bit of convenience here and there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants