server_host.py refactor #2647
Merged
server_host.py refactor #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think the general design of ExecutorServerProcess and ExecutorServer is good. There are a few implementation details I don't like (two-step init, too much API surface), but I would like to tackle those things myself after this is merged.
For now, I just think that we should rename some stuff. Calling classes and variables "server process" makes no sense to me, because everything here is the server. I think we should consistently call the host process/server "host" (like we already kinda do) and the worker process/server "worker" (suffixes are allowed, of course 😄).
RunDevelopment
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors server_host to use a new helper class that manages everything related to the executor process (on top of the already existing class that handles the subprocess itself)
This ultimately fixes the SSE reconnection issue by having this class manage both the process and the connection, allowing both to be restarted easily. (I tested this merged with the backend-killing branch locally, and confirmed this did fix the issue)
This should be merged before #2646