Avoid restarting backend if no deps installed #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a fan. You basically just added an invisible pre-condition to for |
joeyballentine
force-pushed
the
dont-restart-if-no-deps
branch
from
a65a2bc
to
e0f849c
Compare
joeyballentine
changed the title
|
Replaced the other implementation with what you suggested |
RunDevelopment
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the usage of
get_deps_to_installto outside of the installing deps functions. This makes it so that we can choose to not restart the executor server if there are no dependencies installed, which should speed up startup times.