Fix glob negation #2678
Merged
Fix glob negation #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this for now so it does not become stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord link for context: https://discord.com/channels/930865462852591648/930875396277280788/1217655737178656798
Basically, the negate flag wasn't enough. I guess negating doesn't assume you want to match everything that doesnt match the negation by default, so to enable that i had to enable negateall.
Docs for negateall: https://facelessuser.github.io/wcmatch/glob/#negateall. No it wont break regular globs.
Specifically, this enables global pattern negation (which appears to be enabled on glob tester websites). For example, with this you can write
!**/*_ab.*instead of**/!(*_ab).*