Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error reporting #2685

Merged
merged 3 commits into from Mar 19, 2024

Conversation

RunDevelopment
Copy link
Member

This improves the error reporting in 2 ways:

  1. Logged errors will no longer contain the stack trace of the NodeExecutionError. NodeExecutionError is a wrapper to add additional info to errors, its trace doesn't matter.
  2. Send the full stack trace of an error to the frontend. Since the trace isn't usually interesting for users, it's tugged away inside a <details>.

Both changes together should make errors easier to diagnose and fix in the future. Stack traces are now shorter and don't spam logs anymore, and users can send us a full stack trace by simply clicking Copy To Clipboard on an error message.

image


Aside from those changes, I also refactored AlertBoxProvider to extract out the AlertDialog into its own component.

@joeyballentine
Copy link
Member

Awesome

@joeyballentine joeyballentine merged commit 56cb4e7 into chaiNNer-org:main Mar 19, 2024
17 checks passed
@RunDevelopment RunDevelopment deleted the improved-errors branch March 19, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants