Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed punctuation in path type tags #2701

Merged
merged 1 commit into from Mar 21, 2024

Conversation

RunDevelopment
Copy link
Member

Path type tags use direction: rtl to make the ellipsis appear on the left side of the text. However, this is not the only effect of rtl. It also puts punctuation at the end of a string in front.

Example: That path should be C:\, but we'll see something else:
image

Similarly, it will also put punctuation at the start of the string at the end. This messes with Unix-style paths. The follow is supposed to be /home/name:
image

My fix for this issue is quite simple: if the path starts or ends with a punctuation character, don't do direction: rtl. This means that left ellipsis are a windows-only feature now, but that's a small price to pay for correct visuals.

With the fix:
image

@joeyballentine joeyballentine merged commit 9a96013 into chaiNNer-org:main Mar 21, 2024
4 checks passed
@RunDevelopment RunDevelopment deleted the fix-rtl-punct branch March 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants