Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve missing module error logging #2737

Merged
merged 2 commits into from Apr 4, 2024

Conversation

RunDevelopment
Copy link
Member

Instead of having one log line for each module that failed to import something, it will now group all errors by the package that failed to import. This significantly improves the log spam we get on fresh installs when no dependencies are installed.

Failed to import 23 modules:
No module named 'ncnn'  ->  3 modules ...
  ->  packages.chaiNNer_ncnn.settings
  ->  packages.chaiNNer_ncnn.ncnn.processing.upscale_image
  ->  packages.chaiNNer_ncnn.ncnn.utility.interpolate_models
No module named 'onnx'  ->  5 modules ...
  ->  packages.chaiNNer_onnx.onnx.batch_processing.load_models
  ->  packages.chaiNNer_onnx.onnx.io.load_model
  ->  and 3 more ...
No module named 'onnxruntime'  ->  3 modules ...
  ->  packages.chaiNNer_onnx.settings
  ->  packages.chaiNNer_onnx.onnx.processing.remove_background
  ->  packages.chaiNNer_onnx.onnx.processing.upscale_image
No module named 'spandrel'  ->  5 modules ...
  ->  packages.chaiNNer_pytorch.pytorch.io.load_model
  ->  packages.chaiNNer_pytorch.pytorch.iteration.load_models
  ->  and 3 more ...
No module named 'torch'  ->  7 modules ...
  ->  packages.chaiNNer_pytorch.settings
  ->  packages.chaiNNer_pytorch.pytorch.io.save_model
  ->  and 5 more ...

@joeyballentine joeyballentine merged commit aab8c9f into chaiNNer-org:main Apr 4, 2024
14 checks passed
@RunDevelopment RunDevelopment deleted the impr-modukle-log branch April 4, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants