Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Python setup process #2768

Merged
merged 1 commit into from Apr 8, 2024

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Apr 8, 2024

Fixes #2244
Related to #926.

This improves the Python setup process in a few ways:

  1. Fixed a bug where the System Python Path was JSON.parsed. This was a remnant of the old settings system and will always fail now. The system python path will now work correctly.
  2. When we fail to find any system python, we fall back to our integrated python. This was bugged because we passed the function of checking python executable the directory the integrated python executable was in and not the path to the python executable.
  3. I added a dialog for when installing integrated Python fails. This allows the user to easily retry the installation (e.g. after they ensure their internet connection is stable) or switch to their system python (assuming it is in PATH). This should make troubleshooting a lot more user-friendly.
    image

@joeyballentine joeyballentine merged commit c71aaa7 into chaiNNer-org:main Apr 8, 2024
4 checks passed
@RunDevelopment RunDevelopment deleted the impr-python-setup branch April 8, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't download integrated python in windows.
2 participants