Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch Optimizations #871

Merged
merged 7 commits into from
Sep 1, 2022
Merged

PyTorch Optimizations #871

merged 7 commits into from
Sep 1, 2022

Conversation

joeyballentine
Copy link
Member

  • Use memory estimation rather than try/catching

Needs to take into account the fact that the model might be fp16 (.half()'s in-place effect) or not. Not sure how to go about that

@joeyballentine joeyballentine changed the base branch from main to v0.12.0 August 30, 2022 13:20
@joeyballentine joeyballentine marked this pull request as draft August 30, 2022 13:20
@joeyballentine joeyballentine marked this pull request as ready for review September 1, 2022 23:02
@joeyballentine joeyballentine merged commit 8054daa into v0.12.0 Sep 1, 2022
@joeyballentine joeyballentine mentioned this pull request Sep 1, 2022
joeyballentine added a commit that referenced this pull request Sep 4, 2022
* rely on estimated split depth

* possibly more optimizations

* oops

* Fixes

* Fix CPU
joeyballentine added a commit that referenced this pull request Sep 4, 2022
* rely on estimated split depth

* possibly more optimizations

* oops

* Fixes

* Fix CPU
@joeyballentine joeyballentine deleted the poytorch-optimizations branch September 22, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant