Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please implement RestoreFormerPlusPlus #13

Open
zelenooki87 opened this issue Oct 29, 2023 · 3 comments
Open

Please implement RestoreFormerPlusPlus #13

zelenooki87 opened this issue Oct 29, 2023 · 3 comments
Labels
Arch request Request to add support for an architecture

Comments

@zelenooki87
Copy link

Could you please implement support for https://github.com/wzhouxiff/RestoreFormerPlusPlus?
https://github.com/wzhouxiff/RestoreFormerPlusPlus
Thanks

@zelenooki87
Copy link
Author

And also I have question for devs, why not implement GPEN? I have asked number of times before...Is that hard?
Thanks

@RunDevelopment RunDevelopment added the Arch request Request to add support for an architecture label Oct 29, 2023
@joeyballentine
Copy link
Member

Implementing any arch the way i do it is difficult. As for why it was never implemented, it's because my implementation for the currently supported face models was partially based on GFPGAN's repo, which supported codeformer and restoreformer at one point.

I don't particularly enjoy adding support for new arches, so typically I wait until arches start getting used more frequently by the community. As GPEN is a bit older (and codeformer seems to basically always be better than it), I don't really have a good reason to spend time adding support for it.

If RestoreFormerPlusPlus ends up being really useful, I will definitely consider it.

@zelenooki87
Copy link
Author

zelenooki87 commented Nov 6, 2023

Respect your time.
Consider also about implementing IMHO best open source soulution for coloring grayscale images I have tried so far:
https://github.com/piddnad/DDColor
Thanks

@RunDevelopment RunDevelopment transferred this issue from chaiNNer-org/chaiNNer Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch request Request to add support for an architecture
Projects
None yet
Development

No branches or pull requests

3 participants