use exported methods rather than encapsulated ones #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
/lib/request.js
module, these methods are exported:Exporting these methods gives the benefit for those who need extra functionality to extend these methods as needed. However, the inner code does not use these exported modules, rather it uses the private ones (ie
Test
directly) this handicapes the feature, as extending the exported methods practically does nothing.The proposed implementation can be seen on major code bases such as
node
andmocha
; so i believe its a better practice over all.P.S. i needed to override
Test
module to add extra logging on each request sent, but overriding the Test method does nothing.