You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the test fails, we wont be able to tell what's going on just by reading the message.
What have I broke here? Imagine if this fails only in IE running over saucelabs 😸.
If this keeps growing I'm afraid that this can become very confusing like the utilities tests of chaijs/chai.
As @meeber suggested here, I think that we should refactor this test and split it so it has a single assertion per test and better names.
I understand that get-func-name should not grow a lot and will probably stay very simple, but I don't see this as a good reason to not have good descriptive tests.
If you guys agree. I'll be very happy to make a PR addressing this.
The text was updated successfully, but these errors were encountered:
Currently unit tests for
get-func-name
are so tiny and simple that I can just copy and paste it over here 😄I know this is beautiful, but...
What have I broke here? Imagine if this fails only in IE running over saucelabs 😸.
As @meeber suggested here, I think that we should refactor this test and split it so it has a single assertion per test and better names.
I understand that
get-func-name
should not grow a lot and will probably stay very simple, but I don't see this as a good reason to not have good descriptive tests.If you guys agree. I'll be very happy to make a PR addressing this.
The text was updated successfully, but these errors were encountered: