Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow usage of pydantic from Gammapy or pursue something different? #175

Open
chaimain opened this issue Jun 21, 2024 · 2 comments
Open
Labels
question Further information is requested
Milestone

Comments

@chaimain
Copy link
Owner

Pydantic v2 has brought up large changes from its earlier versions (See Migration guide).

Gammapy adapted to these changes in the PR 4750 and in Asgardpy it was done in #165 (some of the changes highlighted here).

There is no "complete" solution to all the input types used in either pipeline. Is it worth investigating the time and effort to make changes in Asgardpy?

So far, no breaking changes have been seen in Asgardpy's workflow.

@chaimain chaimain added the question Further information is requested label Jun 21, 2024
@chaimain
Copy link
Owner Author

  • In this pipeline, we need only 4 custom input types - Angle, Energy, Path and Time.
  • We always need a single entry for Angle and Path types, whereas for Energy (either only min and max, or a range of edges) and Time (intervals with an associated frame type), always a list of entries. Currently only TimeInterval is defined.
  • Only Angle and Energy input types are of astropy.units.Quantity.

@chaimain
Copy link
Owner Author

As the changes will involve breaking the Config structure again (generalized usage of EnergyRangeConfig), it is probably better to make these changes for v0.5.1

@chaimain chaimain added this to the v0.5.1 milestone Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant