Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support Gammapy v1.2 #165

Merged
merged 10 commits into from
Mar 21, 2024
Merged

Update to support Gammapy v1.2 #165

merged 10 commits into from
Mar 21, 2024

Conversation

chaimain
Copy link
Owner

@chaimain chaimain commented Mar 3, 2024

Fixes #152

Changes proposed in this pull request:

  • Update various dependency versions
  • Remove redundant features in asgardpy

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 96.36364% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 99.18%. Comparing base (4b04129) to head (764cc5e).
Report is 4 commits behind head on main.

Files Patch % Lines
src/asgardpy/base/base.py 93.54% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   99.09%   99.18%   +0.08%     
==========================================
  Files          38       38              
  Lines        2328     2338      +10     
==========================================
+ Hits         2307     2319      +12     
+ Misses         21       19       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaimain
Copy link
Owner Author

chaimain commented Mar 3, 2024

TBD:

  • Check pydantic's custom serializer to replace json_encoders in the BaseConfig definition.
  • Wait for autodoc_pydantic's new support or use alternative for the Sphinx docs
  • Also resolve autodoc_pydantic/directives/autodocumenters.py:137: RemovedInSphinx80Warning: The tuple interface of ObjectMember is deprecated. Use (obj.__name__, obj.object) instead.

@chaimain chaimain added this to the v0.5 milestone Mar 5, 2024
@chaimain chaimain added the dependencies Pull requests that update a dependency file label Mar 5, 2024
@chaimain
Copy link
Owner Author

It is better to update the validation and serialization effort on the usage of the new pydantic dependency in a separate PR.

@chaimain chaimain merged commit a353b9b into main Mar 21, 2024
14 of 15 checks passed
@chaimain chaimain deleted the update_package branch June 24, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Gammapy v1.2
1 participant