Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess logging #17

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Conversation

dgenr8
Copy link
Collaborator

@dgenr8 dgenr8 commented Oct 30, 2019

Suppress logging in CheckProofOfWork when using the reference cpuminer.

@dgenr8
Copy link
Collaborator Author

dgenr8 commented Oct 30, 2019

@cryptozeny

@cryptozeny
Copy link
Contributor

cryptozeny commented Oct 30, 2019

i think its not related with this PR, but anyway i report.

i ran your build f344f29, but it seems freezing at startup. testnet. i cannot reproduce, but it randomly appears. i can exit only with killall -9

cmd was ./src/qt/bitcoin-qt -usecashaddr=0 -testnet -printtoconsole

image

after build, first freezing. but from second time, its OK

i can kill freezing chain2 with kill -9 PID

@cryptozeny
Copy link
Contributor

generate 1
ProcessNewBlock, block not accepted (code -32603)

debug.log

2019-10-30 23:37:09 keypool reserve 6
2019-10-30 23:37:09 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-10-30 23:37:09 ERROR: CheckProofOfWork(): hash doesn't match subtarget
2019-10-30 23:37:09 ERROR: CheckProofOfWork(): hash doesn't match subtarget
2019-10-30 23:37:09 ERROR: ContextualCheckBlockHeader(): proof of work failed
2019-10-30 23:37:09 ERROR: ProcessNewBlock: AcceptBlock FAILED
2019-10-30 23:37:09 keypool return 6

@cryptozeny
Copy link
Contributor

image

@cryptozeny
Copy link
Contributor

image

@cryptozeny
Copy link
Contributor

setgenerate true 1 OK as before

@dgenr8
Copy link
Collaborator Author

dgenr8 commented Oct 31, 2019

@cryptozeny Thanks, I pushed an update to this PR to fix a misplaced parenthesis. Please try again.

Be aware that 'generate 1' is unlikely to succeed on testnet because it defaults to 1,000,000 hash tries. At minimum testnet (=mainnet) difficulty you need about 7,000,000 * 600 = about 4,200,000,000 tries. You can enter # of tries in the next parameter.

Unless there's been no block for a while. Then it will probably succeed on the first try.

Anyway it should not return an error anymore.

@cryptozeny
Copy link
Contributor

cryptozeny commented Nov 1, 2019

3d2b1e4 no error on generate 1

2019-11-01 15:23:04 keypool reserve 9
2019-11-01 15:23:04 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:05 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:06 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:07 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:08 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:09 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:10 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:11 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:12 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:13 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:14 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:15 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:17 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:18 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:19 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:20 CreateNewBlock(): total size 1000 txs: 0 fees: 0 sigops 100
2019-11-01 15:23:20 keypool return 9

@cryptozeny
Copy link
Contributor

Be aware that 'generate 1' is unlikely to succeed on testnet because it defaults to 1,000,000 hash tries. At minimum testnet (=mainnet) difficulty you need about 7,000,000 * 600 = about 4,200,000,000 tries. You can enter # of tries in the next parameter.

but out of range

image

@dgenr8
Copy link
Collaborator Author

dgenr8 commented Nov 1, 2019

Rebased to remove duplicate of the 200GB fix.

@dgenr8 dgenr8 merged commit 4f0510d into chain2:master Nov 1, 2019
@dgenr8
Copy link
Collaborator Author

dgenr8 commented Nov 1, 2019

Thanks @cryptozeny!

@dgenr8 dgenr8 deleted the remove_excess_logging branch May 10, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants