Threshold moved to Multisig workbook #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnowosie
force-pushed
the
threshold-in-msig-table
branch
from
31a2fff
to
9bbd829
Compare
pnowosie
force-pushed
the
threshold-in-msig-table
branch
2 times, most recently
from
0b1dbd6
to
79b5b02
Compare
- threshold moved to MSig tab, - new deposit offer title column (memo), - refactoring and more strict error handling
pnowosie
force-pushed
the
threshold-in-msig-table
branch
from
79b5b02
to
d0fe8b8
Compare
c4t-ag
approved these changes
Feb 14, 2023
c4t-ag
pushed a commit
that referenced
this pull request
Feb 24, 2023
- threshold moved to MSig tab, - new deposit offer title column (memo), - refactoring and more strict error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generator is now taking Multisig threshold from Multisig tab, this prevents some msig definitions were skipped from json because its control group was not used in any allocation.
There is new column
Titlein the deposit offers tab to be used as offer's description (memo)It also delivers refactoring to the parsing structures: