Admin API DNS Rebinding mitigation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikos
previously approved these changes
Jun 9, 2023
DerTiedemann
dismissed
knikos’s stale review
The merge-base changed after approval.
DerTiedemann
force-pushed
the
jax/dns_rebinding_fix
branch
4 times, most recently
from
476a119
to
1f560d8
Compare
c4t-ag
previously approved these changes
Jun 14, 2023
DerTiedemann
force-pushed
the
jax/dns_rebinding_fix
branch
from
1f560d8
to
9113a83
Compare
knikos
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on chain4travel/caminogo#263
This PR adds a check so that the admin API has to be enabled with the awareness that its running on localhost. A new flag has to be set in order for it to be started, otherwise the node crashes with an error.
This is in order to sidestep the DNS Rebinding issue.