Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAIP-10 support for account names with . or _ #63

Open
raymondfeng opened this issue Aug 21, 2021 · 3 comments
Open

CAIP-10 support for account names with . or _ #63

raymondfeng opened this issue Aug 21, 2021 · 3 comments

Comments

@raymondfeng
Copy link

Some blockchains such as NEAR uses names such as abc.near or abc.testnet for account ids. See https://docs.near.org/docs/concepts/account.

ENS is another example, such as abc.eth.

It would be desirable to allow such account ids with CAIP-10.

The required change is to relax the regexp for account_address ( [a-zA-Z0-9]{1,64}). It should allow characters such as . and _.

@raymondfeng raymondfeng changed the title CAIP-10 support for account names with . CAIP-10 support for account names with . or _ Aug 21, 2021
@raymondfeng
Copy link
Author

The same is true for CAIP-19 (asset_reference: [-a-zA-Z0-9]{1,64}). The contract address can be a name with . or _.

@mattlockyer
Copy link

any issues with this regex allowing any symbols? or don't care?

e.g. /[a-zA-Z0-9]{1,64}/.test('test@(*%^(*@%^#(%@test')

@shemnon
Copy link
Contributor

shemnon commented Oct 11, 2021

Hedera would benefit from dots in asset references and account addresses too. Our addresses are three non-negative int64s separated by dots. i.e. 0.0.950.

What needs to be done to advance this, does someone need to propose a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants