Perf: updated subscriber socket subsystem #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
merklefruit
reviewed
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Previously all
PublisherSessions(the components keeping track of a publisher connection inside of aSubSocket) where being polled in the same task, because they were all stored in aStreamMap. For small messages and a small number of sessions this is fine, but it means that:For each of the active publisher sessions where happening in a single task.
Updates
This PR spawns each publisher session as a separate task and implements a bi-directional communication channel between the
SubDriverand all of thePublisherSessions. This should be more efficient for larger messages, mixed workloads, and multiple publishers.