Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test example faster #158

Merged
merged 2 commits into from
Jun 6, 2018
Merged

Conversation

corochann
Copy link
Member

@corochann corochann commented Apr 24, 2018

ROCAUCEvaluator will raise ValueError when only one label is contained in the dataset.
This will stop the whole script, but this is evaluation script and not affect to training.
I added a option to ignore this error so that we can keep running the training.

It has another benefit that we can make test example faster.

@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files          81       81           
  Lines        3521     3521           
=======================================
  Hits         2785     2785           
  Misses        736      736

@corochann
Copy link
Member Author

Please merge after #157

@corochann corochann changed the title Test example fast Raise ValueError option for ROCAUCEvaluator May 13, 2018
@corochann corochann changed the title Raise ValueError option for ROCAUCEvaluator Test example faster May 13, 2018
@delta2323
Copy link
Member

Now #157 is merged. Could you merge or rebase the latest master branch?

@corochann
Copy link
Member Author

merged

@delta2323
Copy link
Member

I'm running the example tests.

@corochann
Copy link
Member Author

Can you merge if it is ok? @delta2323 @mottodora

@delta2323
Copy link
Member

LGTM

@delta2323 delta2323 merged commit e09773c into chainer:master Jun 6, 2018
@corochann corochann deleted the test_example_fast branch June 21, 2018 08:08
@mottodora mottodora added this to the 0.4.0 milestone Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants