Fix indexing behavior in NumpyTupleDataset #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 77.08% 77.79% +0.71%
==========================================
Files 89 91 +2
Lines 3875 4067 +192
==========================================
+ Hits 2987 3164 +177
- Misses 888 903 +15 |
corochann
reviewed
Jun 25, 2018
| @@ -35,7 +35,8 @@ def __init__(self, *datasets): | |||
|
|
|||
| def __getitem__(self, index): | |||
| batches = [dataset[index] for dataset in self._datasets] | |||
| if isinstance(index, slice): | |||
| if isinstance(index, slice) or isinstance(index, list) or\ | |||
There was a problem hiding this comment.
you may write
if isinstance(index, (slice, list, numpy.ndarray)):
| @@ -47,6 +55,38 @@ def test_get_item_slice_index(self, data, index): | |||
| for a, e in six.moves.zip(tuple_a, tuple_e): | |||
| numpy.testing.assert_array_equal(a, e) | |||
|
|
|||
| @pytest.mark.parametrize('index', [numpy.asarray([2, 0])]) | |||
There was a problem hiding this comment.
Can you add array with length 1?
| for a, e in six.moves.zip(tuple_a, tuple_e): | ||
| numpy.testing.assert_array_equal(a, e) | ||
|
|
||
| @pytest.mark.parametrize('index', [[2, 0]]) |
There was a problem hiding this comment.
Can you add list with length 1?
|
Fix. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains non compatibility change.