Zinc 250k dataset support #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 27, 2018 19:35
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 89.13% 81.47% -7.67%
==========================================
Files 116 118 +2
Lines 5834 5953 +119
==========================================
- Hits 5200 4850 -350
- Misses 634 1103 +469 |
mottodora
approved these changes
Nov 27, 2018
mottodora
requested changes
Nov 27, 2018
| assert len(dataset) == ZINC250K_NUM_DATASET | ||
|
|
||
|
|
||
| def test_get_zinc_smiles(): |
There was a problem hiding this comment.
This is intentional. I used target_index so this test is not slow.
mottodora
approved these changes
Nov 28, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation almost done, but I'm final checking the function behavior.