Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring method names #3

Merged
merged 2 commits into from
Nov 29, 2017
Merged

refactoring method names #3

merged 2 commits into from
Nov 29, 2017

Conversation

corochann
Copy link
Member

No description provided.

@corochann corochann mentioned this pull request Nov 28, 2017
Merged
delta2323
delta2323 reviewed Nov 29, 2017
View reviewed changes
tests/datasets_tests/test_qm9.py
import pytest

from chainerchem.datasets import qm9
from chainerchem.datasets import qm9, tox21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be considered as a bug. I will fix it later.

@delta2323
Copy link
Member

construct_atomic_numbers sounds weird to me because atomic numbers are determined independently of this library and this function does not construct atomic numbers themselves. How about changing to construct_atomic_number_array or restore the original name?

@corochann
Copy link
Member Author

Before PR there exist get_XXX function and construct_XXX function, so I wanted to unify the name to either of them.

I changed to use construct_XXX for all methods used in preprocessor.
So Is it ok if I change to construct_atomic_number_array?

@delta2323
Copy link
Member

So Is it ok if I change to construct_atomic_number_array?

Yes, I agree with you.

@corochann
Copy link
Member Author

Then could you merge this first, and I will make another PR.

PR #4, #5, #7 already depends on #3, so I want to send another PR.

@delta2323 delta2323 self-assigned this Nov 29, 2017
@delta2323 delta2323 merged commit e52fbe3 into chainer:master Nov 29, 2017
@delta2323 delta2323 mentioned this pull request Nov 29, 2017
Merged
@delta2323 delta2323 added this to the 0.1.0 milestone Dec 26, 2017
corochann pushed a commit that referenced this pull request Oct 3, 2019
@nissy-dev
Merge pull request #3 from nd-02110114/refactor-converter
6bb8d65 
Refactor converter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delta2323 delta2323 delta2323 left review comments

Assignees

@delta2323 delta2323

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@corochann @delta2323