refactor general readout: move to links. #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review? @natsukium |
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
==========================================
- Coverage 89.65% 83.64% -6.02%
==========================================
Files 174 174
Lines 7987 7989 +2
==========================================
- Hits 7161 6682 -479
- Misses 826 1307 +481 |
|
LGTM but it is better to note down in docstring that GeneralReadout class has no parameter and is interpreted as |
|
I think it's good. |
mottodora
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.