Standard scaler link #309
Merged
Standard scaler link #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mottodora
requested changes
Jan 24, 2019
| def _compute_mean_std_all(self, input_dim): | ||
| if self.indices is None: | ||
| std_all = self.xp.ones(input_dim, dtype=self.xp.float32) | ||
| std_all[self.std != 0] = self.std[self.std != 0] |
There was a problem hiding this comment.
It is kind to raise warning when std == 0. Because it is very strange situation.
There was a problem hiding this comment.
updated: show warning at fit.
| if x.ndim == 1: | ||
| # Deal with as 1 feature with several samples. | ||
| x = x[:, None] | ||
| if x.ndim != 2: |
| x = x[:, None] | ||
| if x.ndim != 2: | ||
| raise ValueError( | ||
| "Unexpected value x.shape={}, only x.ndim=2 is supported." |
added 2 commits
January 24, 2019 15:33
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 89.6% 83.78% -5.82%
==========================================
Files 179 182 +3
Lines 8112 8272 +160
==========================================
- Hits 7269 6931 -338
- Misses 843 1341 +498 |
mottodora
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StandardScaler with chainer.Link
there are several benefits:
indices, if specified.