Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setup predictor to Library #336

Merged
merged 5 commits into from
Mar 23, 2019

Conversation

natsukium
Copy link
Collaborator

No description provided.

@natsukium natsukium marked this pull request as ready for review March 22, 2019 01:28
@codecov-io
Copy link

codecov-io commented Mar 22, 2019

Codecov Report

Merging #336 into master will increase coverage by 0.15%.
The diff coverage is 98.7%.

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   80.88%   81.04%   +0.15%     
==========================================
  Files         207      209       +2     
  Lines        9496     9576      +80     
==========================================
+ Hits         7681     7761      +80     
  Misses       1815     1815

@natsukium
Copy link
Collaborator Author

I added kwargs to set_up_predictor.
Please check it.

Copy link
Member

@mottodora mottodora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!!

@mottodora mottodora merged commit d1c6859 into chainer:master Mar 23, 2019
@mottodora mottodora added this to the 0.6.0 milestone Sep 11, 2019
@natsukium natsukium deleted the mv-setup-predictor branch December 22, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants