return svg text in MolVisualizer #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No-compat: The returned value will change to raw When using on jupyter notebook, user need to write below explicitly. |
dtaniwaki
approved these changes
Sep 10, 2019
| @@ -46,9 +46,24 @@ def __init__(self, logger=None): | |||
|
|
|||
| def visualize(self, saliency, mol, save_filepath=None, | |||
| visualize_ratio=1.0, color_fn=red_blue_cmap, | |||
| scaler=abs_max_scaler, legend=''): | |||
| scaler=abs_max_scaler, legend='', raise_import_error=True | |||
There was a problem hiding this comment.
I think raise_import_error should be False by default if we follow the original behavior of saving png files.
There was a problem hiding this comment.
okay i will fix it to set False as default.
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 91.42% 86.64% -4.78%
==========================================
Files 222 222
Lines 10786 10786
==========================================
- Hits 9861 9346 -515
- Misses 925 1440 +515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.