Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing documentations for new optimizer instantiation argument #3938

Closed
hvy opened this issue Nov 22, 2017 · 3 comments
Closed

Missing documentations for new optimizer instantiation argument #3938

hvy opened this issue Nov 22, 2017 · 3 comments
Labels
cat:document Documentation such as function documentations, comments and tutorials.

Comments

@hvy
Copy link
Member

hvy commented Nov 22, 2017

We're currently missing documentations for the arguments introduced by #3488, optimizer instantiation with models.

We should update the docs of the constructors accordingly to expose the new feature!
@hvy hvy added the cat:document Documentation such as function documentations, comments and tutorials. label Nov 22, 2017
@stale
Copy link

stale bot commented Feb 20, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Not updated for a longer period of time. label Feb 20, 2018
@stale
Copy link

stale bot commented Mar 22, 2018

This issue is closed as announced. Feel free to re-open it if needed.

@stale stale bot closed this as completed Mar 22, 2018
@kmaehashi
Copy link
Member

For record, this issue is no longer valid as the optimizer spec has been changed after #3488. Refs #4167.

@kmaehashi kmaehashi removed the stale Not updated for a longer period of time. label Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat:document Documentation such as function documentations, comments and tutorials.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmaehashi @hvy