Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight inaccuracy in NStepGRU docs #6521

Closed
euler16 opened this issue Mar 14, 2019 · 7 comments · Fixed by #8326
Closed

Slight inaccuracy in NStepGRU docs #6521

euler16 opened this issue Mar 14, 2019 · 7 comments · Fixed by #8326
Labels
cat:document Documentation such as function documentations, comments and tutorials. contribution-welcome Contribution is welcomed. If a ticket has this label, anyone is welcomed to work on it. stale Not updated for a longer period of time.

Comments

@euler16
Copy link
Contributor

euler16 commented Mar 14, 2019

in the part where the input dimension has been described , I think it should be L_t instead of L_i

@euler16
Copy link
Contributor Author

euler16 commented Mar 14, 2019

if u could tell me the procedure to make the changes, I can make the correction and do a PR myself.

@toslunar
Copy link
Member

It seems #5979 missed some fixes. Could you make a PR? The contribution guide is https://docs.chainer.org/en/latest/contribution.html.

@toslunar toslunar added the cat:document Documentation such as function documentations, comments and tutorials. label Mar 15, 2019
@kmaehashi kmaehashi added the contribution-welcome Contribution is welcomed. If a ticket has this label, anyone is welcomed to work on it. label Mar 19, 2019
@euler16
Copy link
Contributor Author

euler16 commented Apr 9, 2019

while trying to build the documentation, I am getting the following error

'source file: {}'.format(source_abs_path))
RuntimeError: Couldn't parse root directory from source file: /home/rajivratn/anaconda2/envs/chain/lib/python3.6/site-packages/chainer/serializer.py

@toslunar after searching the codebase, i think the error is emanating from conf.py in doc/src.
could you tell me how to fix this?

@euler16
Copy link
Contributor Author

euler16 commented Apr 9, 2019

I overcame the above issue

@euler16
Copy link
Contributor Author

euler16 commented Apr 9, 2019

I have sent a PR for the same. made sure I ran autopep8 and flake8 before sending PR.

@stale
Copy link

stale bot commented Jul 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Not updated for a longer period of time. label Jul 8, 2019
@stale
Copy link

stale bot commented Aug 7, 2019

This issue is closed as announced. Feel free to re-open it if needed.

@stale stale bot closed this as completed Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:document Documentation such as function documentations, comments and tutorials. contribution-welcome Contribution is welcomed. If a ticket has this label, anyone is welcomed to work on it. stale Not updated for a longer period of time.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants