Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix n-step RNN docs #8326

Merged
merged 9 commits into from
Nov 11, 2019
Merged

Fix n-step RNN docs #8326

merged 9 commits into from
Nov 11, 2019

Conversation

toslunar
Copy link
Member

Takeover #6808: fix #6521 and fix #6810.

@toslunar toslunar added cat:document Documentation such as function documentations, comments and tutorials. to-be-backported Pull request that should be backported. takeover Pull request that has been taken over from an external contributor. labels Oct 28, 2019
@kmaehashi
Copy link
Member

pfnCI, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 99bcba7, target branch master) failed with status FAILURE.

@kmaehashi
Copy link
Member

/test

@toslunar
Copy link
Member Author

toslunar commented Nov 8, 2019

Only ../../../repo/tests/chainerx_tests/unit_tests/routines_tests/test_linalg.py::test_CholeskyFailing_param_7_{in_dtypes='float64', shape=(3, 3)}[cuda:0] is failed (#8362). Could you merge the PR?

@kmaehashi kmaehashi merged commit 66b58ad into chainer:master Nov 11, 2019
@kmaehashi
Copy link
Member

LGTM! Test failures are not related to this PR.

@kmaehashi kmaehashi added this to the v7.0.0 milestone Nov 11, 2019
kmaehashi added a commit to kmaehashi/chainer that referenced this pull request Nov 11, 2019
@kmaehashi
Merge pull request chainer#8326 from toslunar/fix/rnn-doc
b50c847 
Fix n-step RNN docs
@kmaehashi kmaehashi mentioned this pull request Nov 11, 2019
Merged
@toslunar toslunar mentioned this pull request Nov 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kmaehashi kmaehashi

Labels
cat:document Documentation such as function documentations, comments and tutorials. takeover Pull request that has been taken over from an external contributor. to-be-backported Pull request that should be backported.
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.

Adding a usage example to NStepLSTM. Slight inaccuracy in NStepGRU docs
5 participants
@toslunar @kmaehashi @chainer-ci @euler16 @Crissman